diff options
Diffstat (limited to 'reviews')
| -rw-r--r-- | reviews/blog-roll.md | 18 | ||||
| -rw-r--r-- | reviews/stack.org | 3 |
2 files changed, 18 insertions, 3 deletions
diff --git a/reviews/blog-roll.md b/reviews/blog-roll.md index e9113fc..796d214 100644 --- a/reviews/blog-roll.md +++ b/reviews/blog-roll.md @@ -121,3 +121,21 @@ enough hindsight to find where that thought process fell short. [Bartosz Ciechanowski]: https://ciechanow.ski/ [Alpha Compositing]: https://ciechanow.ski/alpha-compositing/ + +# [Red Hat Developer] + +[10 tips for reviewing code you don't like] +: The article could basically be included as-is in a [nonviolent + communication] textbook and renamed "application to code reviews". + + AFAICT the underlying principle to all these tips is: scrub + judgmental statements out of your responses, and state your + concerns openly. Nobody should expect you to hold all the + answers; express your uncertainty, and let the submitter do the + work of convincing you (e.g. checking for performance regressions, + splitting patch series). + + +[Red Hat Developer]: https://developers.redhat.com/blog/ +[10 tips for reviewing code you don't like]: https://developers.redhat.com/blog/2019/07/08/10-tips-for-reviewing-code-you-dont-like/ +[nonviolent communication]: https://en.wikipedia.org/wiki/Nonviolent_Communication diff --git a/reviews/stack.org b/reviews/stack.org index 3d99b87..f5c7132 100644 --- a/reviews/stack.org +++ b/reviews/stack.org @@ -1,9 +1,6 @@ A list of things I plan on reading someday, or have read but have not yet commented on. -* [[https://developers.redhat.com/blog/2019/07/08/10-tips-for-reviewing-code-you-dont-like/][10 tips for reviewing code you don’t like]] -Somewhat topical with the [[https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00246.html][recent clash on emacs-devel]]. - * [[https://blog.regehr.org/archives/1676][It’s Time for a Modern Synthesis Kernel]] * Rust stuff |